[
https://issues.apache.org/jira/browse/DL-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sijie Guo resolved DL-124.
--------------------------
Resolution: Fixed
Issue resolved by merging pull request 133
[https://github.com/apache/incubator-distributedlog/pull/133]
{noformat}
commit 53fca4ac30c0d0f769940669be79c53dcaee3a23
Author: Sijie Guo <[email protected]>
AuthorDate: Wed Jun 21 10:20:15 2017 -0700
Commit: Sijie Guo <[email protected]>
CommitDate: Wed Jun 21 10:20:15 2017 -0700
DL-124: Use Java8 Future rather than twitter Future
Switch to use Java8 CompletableFuture, to reduce dependencies introduced by
twitter future and make it more friendly to users (users don't think of using
which version of scala).
This change is based on #132 . Gitsha ce0686e is the change to review.
The changes:
- Change Future to CompletableFuture
- Map to thenApply
- flatMap to thenCompose
- Added a FutureEventListener, and switch addEvenListener to whenComplete
(or whenCompleteAsync)
- setValue to complete
- setException to completeExceptionally
- add rescue, ignore, ensure to FutureUtils as util functions.
Author: Sijie Guo <[email protected]>
Reviewers: Jia Zhai <None>, Leigh Stewart <[email protected]>
Closes #133 from sijie/change_twitter_future_to_java_future
{noformat}
> Use Java8 Future rather than twitter Future
> -------------------------------------------
>
> Key: DL-124
> URL: https://issues.apache.org/jira/browse/DL-124
> Project: DistributedLog
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Gerrit Sundaram
> Assignee: Sijie Guo
> Labels: help-wanted
> Fix For: 0.5.0
>
>
> Since it is written in java, it would be good to leverage java8 future rather
> than introducing dependencies on scala.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
