[
https://issues.apache.org/jira/browse/DL-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102551#comment-16102551
]
ASF GitHub Bot commented on DL-2:
---------------------------------
GitHub user zhaijack opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/135
(WIP) DL-2: DistributedLog should work with the official apache bookkeeper
This change is to upgrade bookkeeper version to BK 4.5.0. (It is still WIP)
- upgrade bookkeeper version to 4.5.0-SNAPSHOT (still waiting a few pull
requests to merge apache/bookkeeper#297 apache/bookkeeper#287
- change registerSuccessEvent for StatsLogger to add TimeUnit
- use netty4 eventloop
- move twitter repository dependencies to proxy related module only. core
library will not depend on scala dependency anymore.
This change is a collaboration change with @sijie
We will provide a performance comparison between 0.4.0 (using Twitter BK)
and 0.5.0 (using BK 4.5.) in a separate pull request or email.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhaijack/incubator-distributedlog
bump_dl_version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #135
----
commit 2f25d9fead78d982920fe72720b5470a5cb949f7
Author: Sijie Guo <[email protected]>
Date: 2017-07-19T23:33:46Z
Bump BK version to 4.5.0-SNAPSHOT
- registerSuccessEvent and registerFailureEvent needs TimeUnit
- change HashedWheelTimer to netty 4
- change channelFactory to eventLoopGroup
commit ccd74487da38d0fde64569005b777fea658a0adb
Author: Jia Zhai <[email protected]>
Date: 2017-07-27T01:07:52Z
DL-2: DistributedLog should work with the official apache bookkeeper version
----
> DistributedLog should work with the official apache bookkeeper
> --------------------------------------------------------------
>
> Key: DL-2
> URL: https://issues.apache.org/jira/browse/DL-2
> Project: DistributedLog
> Issue Type: Task
> Components: distributedlog-core
> Reporter: Sijie Guo
> Assignee: Jia Zhai
> Fix For: 0.5.0
>
>
> Currently the version of bookkeeper that distributedlog depends on is
> Twitter's version. http://distributedlog.io/operations/bookkeeper.html
> It is twitter's production version 4.3.4-TWTTR, which is available in
> https://github.com/twitter/bookkeeper
> Once the major Twitter's bookkeeper changes (BOOKKEEPER-670, BOOKKEEPER-759
> and BOOKKEEPER-757) merged into main master, we should change pom files to
> use the official bookkeeper versions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
