[incubator-dlab] 02/03: [DLAB-290]: added hint for commit trimmed field

[ankovalyshyn]

This is an automated email from the ASF dual-hosted git repository.

ankovalyshyn pushed a commit to branch DLAB-4
in repository https://gitbox.apache.org/repos/asf/incubator-dlab.git

commit 3b3842673c5a0b6d97228925c8ecb3cb58c3c528
Author: Andriana Kovalyshyn <andriana_kovalys...@epam.com>
AuthorDate: Mon May 13 12:56:59 2019 +0300

    [DLAB-290]: added hint for commit trimmed field
---
 .../resources/webapp/src/app/shared/navbar/navbar.component.html     | 2 +-
 .../resources/webapp/src/app/shared/navbar/navbar.component.scss     | 5 ++++-
 .../main/resources/webapp/src/app/shared/navbar/navbar.component.ts  | 2 +-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git 
a/services/self-service/src/main/resources/webapp/src/app/shared/navbar/navbar.component.html
 
b/services/self-service/src/main/resources/webapp/src/app/shared/navbar/navbar.component.html
index 8bb75c9..6c3ca0f 100644
--- 
a/services/self-service/src/main/resources/webapp/src/app/shared/navbar/navbar.component.html
+++ 
b/services/self-service/src/main/resources/webapp/src/app/shared/navbar/navbar.component.html
@@ -58,7 +58,7 @@
           </p>
           <p>
             <strong>Revision: </strong>
-            <span class="ellipsis">{{ metadata?.commit }}</span>
+            <span class="ellipsis commit" matTooltip="{{ metadata?.commit }}" 
matTooltipPosition="above">{{ metadata?.commit }}</span>
           </p>
           <p>
             <a class="helper_instruction" 
[attr.href]="metadata?.release_notes" target="_blank">
diff --git 
a/services/self-service/src/main/resources/webapp/src/app/shared/navbar/navbar.component.scss
 
b/services/self-service/src/main/resources/webapp/src/app/shared/navbar/navbar.component.scss
index 45bc4da..e941536 100644
--- 
a/services/self-service/src/main/resources/webapp/src/app/shared/navbar/navbar.component.scss
+++ 
b/services/self-service/src/main/resources/webapp/src/app/shared/navbar/navbar.component.scss
@@ -103,7 +103,7 @@
       width: 120px;
       display: inline-block;
     }
-    .helper_instructiongit {
+    .helper_instruction {
       font-size: 14px;
       i {
         vertical-align: bottom;
@@ -115,6 +115,9 @@
       vertical-align: bottom;
     }
   }
+  .commit {
+    cursor: pointer;
+  }
 }
 a.nav-item {
   position: relative;
diff --git 
a/services/self-service/src/main/resources/webapp/src/app/shared/navbar/navbar.component.ts
 
b/services/self-service/src/main/resources/webapp/src/app/shared/navbar/navbar.component.ts
index aab32e2..ef87728 100644
--- 
a/services/self-service/src/main/resources/webapp/src/app/shared/navbar/navbar.component.ts
+++ 
b/services/self-service/src/main/resources/webapp/src/app/shared/navbar/navbar.component.ts
@@ -204,7 +204,7 @@ export class NavbarComponent implements OnInit, OnDestroy {
   public checkVersionData(): void {
     this.healthStatusService.getAppMetaData().subscribe(
       result => this.metadata = result || null,
-      error => console.log(error));
+      error => this.toastr.error('Metadata loading failed!', 'Oops!'));
   }
 
   private selectQuotesAlert(type: string, user_quota?: number, total_quota?: 
number): string {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@dlab.apache.org
For additional commands, e-mail: commits-h...@dlab.apache.org