clay4444 opened a new pull request #1490: fix AbstractTask's handle method 
exception
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1490
 
 
   
   ## What is the purpose of the pull request
   
   This pull request is mainly fix the bug of AbstractTask class;
   
   when the task is executed by TaskScheduleThread, task.handle () will be 
called to trigger the execution logic of the task itself. If the task throw a 
exception, it will capture and call the kill () method to kill the task and set 
the task status to failed 
   
   However, when each task subclass overrides the handle () method, it chooses 
to catch the exception itself and print the error log without throwing it. 
   
   This will cause the TaskScheduleThread thread to execute task but can't 
catch the task exception forever. The logic of killing the task cannot be 
triggered forever, and the completion status of the task may not be set 
correctly.
   
   
   ## Brief change log
   
   add throw e to subclass of AbstractTask
   
   ## Verify this pull request
   
   This pull request is bug fix without any test coverage.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to