lenboo commented on a change in pull request #1532: fix
MasterBaseTaskExecThread submit method bug
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1532#discussion_r360352102
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java
##########
@@ -74,6 +74,9 @@ public TaskInstance getTaskInstance(){
public Boolean submitWaitComplete() {
Boolean result = false;
this.taskInstance = submit();
+ if(this.taskInstance == null){
+ return result;
Review comment:
should this return be checked whether the process instance is can be
continue normally?
i am not sure about this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
