[GitHub] [incubator-dolphinscheduler] samz406 opened a new pull request #1593: API service adds some test cases

[GitBox]

samz406 opened a new pull request #1593: API service adds some test cases
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1593
 
 
   What is the purpose of the pull request
   
   For 
[#1465](https://github.com/apache/incubator-dolphinscheduler/issues/1465) .
   
   API service adds some test cases
   **Brief change log**
   
   
   
   **add Test class**
   
   AccessTokenServiceTest.java
   
   QueueServiceTest.java
   
   MonitorServiceTest.java
   
   SessionServiceTest.java
   
   UsersServiceTest.java
   
   TenantServiceTest.java
   
   WorkerGroupServiceTest.java
   
   UdfFuncServiceTest.java
   
   AlertGroupServiceTest.java
   
   ProjectServiceTest.java
   
   
   
   **modify service class**
   
   
   
   AccessTokenService      
   
    UdfFuncService         
   
   AlertGroupService
   
   UsersService
   
   WorkerGroupService
   
   CheckUtils
   
   
   
   
   
   **Add root pom.xml as follow**
   
   
   
   `<include>**/api/service/AccessTokenServiceTest.java</include>
   <include>**/api/service/QueueServiceTest.java</include>`
   `<include>**/api/service/MonitorServiceTest.java</include>
   <include>**/api/service/SessionServiceTest.java</include>`
   `<include>**/api/service/UsersServiceTest.java</include>
   <include>**/api/service/TenantServiceTest.java</include>`
   `<include>**/api/service/WorkerGroupServiceTest.java</include>
   <include>**/api/service/UdfFuncServiceTest.java</include>`
   `<include>**/api/service/AlertGroupServiceTest.java</include>
   <include>**/api/service/ProjectServiceTest.java</include>`
   
   
   
   **add api pom.xml as follow**
   
   
   
   ```
   <dependency>
     <groupId>org.powermock</groupId>
     <artifactId>powermock-module-junit4</artifactId>
     <scope>test</scope>
   </dependency>
   
   <dependency>
     <groupId>org.powermock</groupId>
     <artifactId>powermock-api-mockito2</artifactId>
     <scope>test</scope>
     <exclusions>
       <exclusion>
         <groupId>org.mockito</groupId>
         <artifactId>mockito-core</artifactId>
       </exclusion>
     </exclusions>
   </dependency>
   ```
   
   **Verify this pull request**
   
   
   
   **other**
   
   MonitorServiceTest.java need zk server.Test case temporary comments
   
   由于MonitorServiceTest.java需要zk获取master和worker服务，单元测试暂时注释
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services