This is an automated email from the ASF dual-hosted git repository.
journey pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 7826843 update token add exist check (#1598)
7826843 is described below
commit 7826843620fb31d312f13a017dbf06e3d7ef5e25
Author: samz406 <[email protected]>
AuthorDate: Fri Dec 27 15:02:49 2019 +0800
update token add exist check (#1598)
* misspell words
* modify common queue TaskQueueZKImplTest.java unit test
* extends BaseTaskQueueTest get zkServer
* modify zk config
* updateToken add entity exist check
---
.../apache/dolphinscheduler/api/service/AccessTokenService.java | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AccessTokenService.java
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AccessTokenService.java
index 4664b59..897646b 100644
---
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AccessTokenService.java
+++
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AccessTokenService.java
@@ -154,8 +154,13 @@ public class AccessTokenService extends BaseService {
*/
public Map<String, Object> updateToken(int id,int userId, String
expireTime, String token) {
Map<String, Object> result = new HashMap<>(5);
- AccessToken accessToken = new AccessToken();
- accessToken.setId(id);
+
+ AccessToken accessToken = accessTokenMapper.selectById(id);
+ if (accessToken == null) {
+ logger.error("access token not exist, access token id {}", id);
+ putMsg(result, Status.ACCESS_TOKEN_NOT_EXIST);
+ return result;
+ }
accessToken.setUserId(userId);
accessToken.setExpireTime(DateUtils.stringToDate(expireTime));
accessToken.setToken(token);