Technoboy- commented on a change in pull request #1607: project checkResult may
NPE
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1607#discussion_r361605678
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProjectService.java
##########
@@ -143,7 +143,7 @@
public boolean hasProjectAndPerm(User loginUser, Project project,
Map<String, Object> result) {
boolean checkResult = false;
if (project == null) {
- putMsg(result, Status.PROJECT_NOT_FOUNT, project.getName());
+ putMsg(result, Status.PROJECT_NOT_FOUNT, "");
Review comment:
We should tell users which projectName is not found ,not empty
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services