lgcareer commented on a change in pull request #1579: add alert server comments
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1579#discussion_r361618240
##########
File path:
dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
##########
@@ -60,20 +63,17 @@ public void start(){
logger.info("alert server ready start ");
while (Stopper.isRunning()){
try {
- Thread.sleep(Constants.ALERT_SCAN_INTERVEL);
+ Thread.sleep(Constants.ALERT_SCAN_INTERVAL);
} catch (InterruptedException e) {
logger.error(e.getMessage(),e);
}
List<Alert> alerts = alertDao.listWaitExecutionAlert();
alertSender = new AlertSender(alerts, alertDao);
alertSender.run();
}
- }
-
- public static void main(String[] args){
- AlertServer alertServer = AlertServer.getInstance();
Review comment:
I have the same question,why remove the main method?AlertServer now is a
independent service
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
