clay4444 opened a new pull request #1686: Fix SessionService signOut method exception handle bug URL: https://github.com/apache/incubator-dolphinscheduler/pull/1686 # What is the purpose of the pull request this pr is for fix the bug of SessionService's signOut method. In the current implementation, the exception is caught, but there is a empty handle. in LoginController's signOut method, This method determines whether to exit successfully by catching an exception, this will cause the method to always return success even if an exception occurs on the SessionService's signOut method. ## Verify this pull request This pull request is already covered by existing tests SessionServiceTest.testSignOut()
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
