clay4444 opened a new pull request #1713: Refactor alert template URL: https://github.com/apache/incubator-dolphinscheduler/pull/1713 ## What is the purpose of the pull request this pr is for refactor alert template, remove FreeMarker. link issue #1691 ## Brief change log 1. remove freemarker 2. define an abstract class and provide a default implementation. The implementation method is concat string. The reason for not using interfaces is to consider the problem of code reuse. 3. provide a factory class to select a specific implementation class based on user configuration ## Verify this pull request This change added tests and can be verified as follows: - *Added AlertTemplateFactoryTest test class for AlertTemplateFactory.* - *Added DefaultHTMLTemplateTest test class for DefaultHTMLTemplateTest.* - *Manually verified the change by testing locally ( for MailUtilsTest ).*
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
