gabrywu opened a new issue #1831: [Feature] AbstractCommandExecutor.commandType difficult to understand URL: https://github.com/apache/incubator-dolphinscheduler/issues/1831 ## Background In the AbstractCommandExecutor class ,commandType function is used to stitching the final command strings. `processBuilder.command("sudo", "-u", tenantCode, commandType(), commandFile);` That is difficult to understand, which even is ambiguous. Why not rename commandType function a better name ## Suggestion rename 'commandType' to 'rootCommand'
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
