codecov-io commented on issue #1954: Fix socket bug: read before sock connect. 
Add UT for FourLetterWordMain.
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1954#issuecomment-586061859
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954?src=pr&el=h1)
 Report
   > Merging 
[#1954](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954?src=pr&el=desc)
 into 
[dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/d204aa13c03456544a227a07e43b888b433f318e?src=pr&el=desc)
 will **increase** coverage by `1.92%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #1954      +/-   ##
   ============================================
   + Coverage     25.27%   27.19%   +1.92%     
   - Complexity     1322     1383      +61     
   ============================================
     Files           312      312              
     Lines         16642    16643       +1     
     Branches       2048     2048              
   ============================================
   + Hits           4206     4526     +320     
   + Misses        11978    11639     -339     
   - Partials        458      478      +20
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954?src=pr&el=tree)
 | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...hinscheduler/dao/datasource/ConnectionFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQ29ubmVjdGlvbkZhY3RvcnkuamF2YQ==)
 | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...e/dolphinscheduler/server/worker/WorkerServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9Xb3JrZXJTZXJ2ZXIuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...nscheduler/common/job/db/ClickHouseDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9DbGlja0hvdXNlRGF0YVNvdXJjZS5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...che/dolphinscheduler/common/utils/CommonUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0NvbW1vblV0aWxzLmphdmE=)
 | `40% <0%> (+40%)` | `5 <0> (+5)` | :arrow_up: |
   | 
[...apache/dolphinscheduler/alert/utils/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9Db25zdGFudHMuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...e/dolphinscheduler/server/master/MasterServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9NYXN0ZXJTZXJ2ZXIuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=)
 | `40.1% <0%> (ø)` | `14 <0> (ø)` | :arrow_down: |
   | 
[.../dolphinscheduler/dao/utils/cron/CycleFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3V0aWxzL2Nyb24vQ3ljbGVGYWN0b3J5LmphdmE=)
 | `34.72% <0%> (-0.49%)` | `5 <0> (ø)` | |
   | 
[.../apache/dolphinscheduler/api/utils/CheckUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL0NoZWNrVXRpbHMuamF2YQ==)
 | `61.53% <0%> (+9.53%)` | `19 <0> (+3)` | :arrow_up: |
   | 
[...dolphinscheduler/api/service/ResourcesService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUmVzb3VyY2VzU2VydmljZS5qYXZh)
 | `79.66% <0%> (ø)` | `67 <0> (ø)` | :arrow_down: |
   | ... and [23 
more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954?src=pr&el=footer).
 Last update 
[d204aa1...60346f3](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1954?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to