codecov-io edited a comment on issue #1948: process null check&add UT&remove duplicate code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1948#issuecomment-586323723 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948?src=pr&el=h1) Report > Merging [#1948](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/77023aee1b999a18afbb073484d0ed0bea8e9806?src=pr&el=desc) will **increase** coverage by `1.65%`. > The diff coverage is `14.09%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## dev #1948 +/- ## ============================================ + Coverage 28.73% 30.39% +1.65% + Complexity 1487 1367 -120 ============================================ Files 312 294 -18 Lines 16810 14964 -1846 Branches 2082 1800 -282 ============================================ - Hits 4831 4548 -283 + Misses 11471 9964 -1507 + Partials 508 452 -56 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...nscheduler/dao/datasource/SQLServerDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvU1FMU2VydmVyRGF0YVNvdXJjZS5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | | | [...hinscheduler/dao/datasource/PostgreDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvUG9zdGdyZURhdGFTb3VyY2UuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | | | [...phinscheduler/dao/datasource/OracleDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvT3JhY2xlRGF0YVNvdXJjZS5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | | | [...olphinscheduler/dao/datasource/HiveDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvSGl2ZURhdGFTb3VyY2UuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | | | [...uler/api/controller/ProcessInstanceController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvUHJvY2Vzc0luc3RhbmNlQ29udHJvbGxlci5qYXZh) | `2.43% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [...hinscheduler/dao/datasource/DataSourceFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvRGF0YVNvdXJjZUZhY3RvcnkuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | | | [...e/dolphinscheduler/common/utils/Preconditions.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1ByZWNvbmRpdGlvbnMuamF2YQ==) | `0% <ø> (-63.16%)` | `0 <0> (-20)` | | | [...dolphinscheduler/server/monitor/ZKMonitorImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvWktNb25pdG9ySW1wbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...he/dolphinscheduler/server/utils/RemoveZKNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1JlbW92ZVpLTm9kZS5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...phinscheduler/api/service/TaskInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGFza0luc3RhbmNlU2VydmljZS5qYXZh) | `5.12% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | ... and [59 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948?src=pr&el=footer). Last update [77023ae...87cb33b](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1948?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
