gabrywu commented on a change in pull request #1963: fix checkOtherParams
invoke logic
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1963#discussion_r379901576
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java
##########
@@ -922,7 +922,11 @@ public void importSubProcess(User loginUser, Project
targetProject, JSONArray js
}
// check extra params
- CheckUtils.checkOtherParams(taskNode.getExtras());
+ if(taskNode.getExtras() !=null &&
!CheckUtils.checkOtherParams(taskNode.getExtras())){
Review comment:
I think null is valid params
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
