Jave-Chen edited a comment on issue #1955: [BUG] ProcessUtils.kill blocked
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1955#issuecomment-586772086
 
 
   > > I think we should add a killType not taskType.
   > > For example, killType = KILL_BY_ID will killl task by task id, killType 
= KiLL_BY_LOG will kill task by log content.
   > 
   > Not only kill task need to read task log , for example whether SHELL task 
status success or failure ,
   > first of all judge shell exit code status , second judge for yarn or 
messos resources negotiator status . so necessary resources negotiator type to 
user choice
   
   agree
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to