gaojun2048 commented on a change in pull request #1970: Add ambari plugin #1469 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1970#discussion_r380418131
########## File path: ambari_plugin/common-services/DOLPHIN/1.2.1/configuration/dolphin-env.xml ########## @@ -0,0 +1,114 @@ +<configuration> + <property> + <name>dolphin.database.type</name> + <value>mysql</value> + <description>Dolphin Scheduler DataBase Type Which Is Select</description> + <display-name>Dolphin Database Type</display-name> + <value-attributes> + <type>value-list</type> + <entries> + <entry> + <value>mysql</value> + <label>Mysql</label> + </entry> + <entry> + <value>postgresql</value> + <label>Postgresql</label> + </entry> + </entries> + <selection-cardinality>1</selection-cardinality> + </value-attributes> + <on-ambari-upgrade add="true"/> + </property> + + <property> + <name>dolphin.database.host</name> + <value>ark1</value> Review comment: if dolphin.database.host is must be config , it is recommended to set this parameter as required instead of giving an unavailable default value.The same goes for other parameters. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
