khadgarmage commented on a change in pull request #1978: Refactor dockerfile
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1978#discussion_r381672478
##########
File path: dockerfile/hooks/build
##########
@@ -15,10 +15,21 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-
echo "------ dolphinscheduler start - build -------"
printenv
-docker build --build-arg version=$version --build-arg tar_version=$tar_version
-t $DOCKER_REPO:$version .
+echo -e "Current Directory is $(pwd)\n"
+
+# maven package(Project Directory)
+echo -e "mvn clean compile package -Prelease"
+mvn clean compile package -Prelease
+
+# mv dolphinscheduler-bin.tar.gz file to dockerfile directory
+echo -e "mv
$(pwd)/dolphinscheduler-dist/target/apache-dolphinscheduler-incubating-${VERSION}-SNAPSHOT-dolphinscheduler-bin.tar.gz
$(pwd)/dockerfile/\n"
Review comment:
It is better to build image based on the current branch code, both CI and
release can be used, rather than build based on the package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
