gabrywu commented on a change in pull request #1999: Adapting partial code(file
name start with E) to the sonar cloud rule
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1999#discussion_r382969544
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java
##########
@@ -378,10 +376,10 @@ private boolean checkTenantSuitable(ProcessDefinition
processDefinition) {
List<Integer> ids = new ArrayList<>();
processService.recurseFindSubProcessId(processDefineId, ids);
Integer[] idArray = ids.toArray(new Integer[ids.size()]);
- if (ids.size() > 0){
+ if (!ids.isEmpty()){
Review comment:
Why? check if null additional? unnecessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
