wenhemin commented on a change in pull request #2063: fix ugly logger usage
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/2063#discussion_r386814198
##########
File path:
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -116,12 +116,12 @@ public ProcessInstance handleCommand(Logger logger,
String host, int validThread
ProcessInstance processInstance = constructProcessInstance(command,
host);
//cannot construct process instance, return null;
if(processInstance == null){
- logger.error("scan command, command parameter is error: %s",
command.toString());
+ logger.error("scan command, command parameter is error: {}",
command);
moveToErrorCommand(command, "process instance is null");
return null;
}
if(!checkThreadNum(command, validThreadNum)){
- logger.info("there is not enough thread for this command:
{}",command.toString() );
+ logger.info("there is not enough thread for this command:
{}",command );
return setWaitingThreadProcess(command, processInstance);
}
Review comment:
,command ); -> ", command);
beautify format, Unified formatting is recommended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
