Rubik-W opened a new issue #2112: [BUG] many dependent tasks depend on a node, task status bug URL: https://github.com/apache/incubator-dolphinscheduler/issues/2112 **Describe the bug** When many dependent tasks depend on a node and the dependent task supports failed retry, the task that submitted the retry will be judged as kill. causes process instance to fail. I think, no need to verify process strategy when submitting tasks. The method updateProcessInstanceState of the MasterExecThread class has been verify process strategy. ``` private void updateProcessInstanceState() { ExecutionStatus state = getProcessInstanceState(); if(processInstance.getState() != state){ ``` ``` private ExecutionStatus getProcessInstanceState(){ ProcessInstance instance = processService.findProcessInstanceById(processInstance.getId()); ExecutionStatus state = instance.getState(); if(activeTaskNode.size() > 0){ return runningState(state); } // process failure if(processFailed()){ return ExecutionStatus.FAILURE; } ``` ``` private Boolean processFailed(){ if(hasFailedTask()) { if(processInstance.getFailureStrategy() == FailureStrategy.END){ return true; } if (processInstance.getFailureStrategy() == FailureStrategy.CONTINUE) { return readyToSubmitTaskList.size() == 0 || activeTaskNode.size() == 0; } } return false; } ``` **Which version of Dolphin Scheduler:** -[1.2.0-preview]
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
