This is an automated email from the ASF dual-hosted git repository.

journey pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new b2268b1  use stringbuilder to append string (#2108)
b2268b1 is described below

commit b2268b1af9bdab3162a4c6378c85a936ce00827f
Author: tswstarplanet <[email protected]>
AuthorDate: Sun Mar 8 15:57:06 2020 +0800

    use stringbuilder to append string (#2108)
---
 .../dolphinscheduler/service/zk/AbstractZKClient.java  | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git 
a/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/AbstractZKClient.java
 
b/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/AbstractZKClient.java
index 135bfda..fa1a0bf 100644
--- 
a/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/AbstractZKClient.java
+++ 
b/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/AbstractZKClient.java
@@ -65,14 +65,16 @@ public abstract class AbstractZKClient extends 
ZookeeperCachedOperator {
                        if (splits.length != 
Constants.HEARTBEAT_FOR_ZOOKEEPER_INFO_LENGTH){
                                return;
                        }
-                       String str = splits[0] + Constants.COMMA
-                                       + splits[1] + Constants.COMMA
-                                       + OSUtils.cpuUsage() + Constants.COMMA
-                                       + OSUtils.memoryUsage() + 
Constants.COMMA
-                                       + OSUtils.loadAverage() + 
Constants.COMMA
-                                       + splits[5] + Constants.COMMA
-                                       + DateUtils.dateToString(new Date());
-                       zkClient.setData().forPath(znode,str.getBytes());
+                       StringBuilder sb = new StringBuilder();
+                       sb.append(splits[0]).append(Constants.COMMA)
+                                       
.append(splits[1]).append(Constants.COMMA)
+                                       
.append(OSUtils.cpuUsage()).append(Constants.COMMA)
+                                       
.append(OSUtils.memoryUsage()).append(Constants.COMMA)
+                                       
.append(OSUtils.loadAverage()).append(Constants.COMMA)
+                                       
.append(splits[5]).append(Constants.COMMA)
+                                       .append(DateUtils.dateToString(new 
Date()));
+
+                       zkClient.setData().forPath(znode, 
sb.toString().getBytes());
 
                } catch (Exception e) {
                        logger.error("heartbeat for zk failed", e);

Reply via email to