[GitHub] [incubator-dolphinscheduler] Rubik-W edited a comment on issue #2112: [BUG] many dependent tasks depend on a node, task status bug

[GitBox]

Rubik-W edited a comment on issue #2112: [BUG] many dependent tasks depend on a 
node, task status bug
URL: 
https://github.com/apache/incubator-dolphinscheduler/issues/2112#issuecomment-597992664
 
 
   New modification plan:
   1.The method runProcess() of the MasterExecThread class. Update instance 
status before submitting task.
   
   ```
               updateProcessInstanceState();
   
               if (canSubmitTaskToQueue()) {
                   submitStandByTask();
               }
   
               if (processInstance.IsProcessInstanceStop()) {
                   break;
               }
   
               try {
                   Thread.sleep(Constants.SLEEP_TIME_MILLIS);
               } catch (InterruptedException e) {
                   logger.error(e.getMessage(),e);
               }
   ```
   
   2.The method getSubmitTaskState() of the ProcessDao class. If instance 
status is failure, the task status is set to kill.
   
   ```
           if( processInstanceState == ExecutionStatus.READY_PAUSE){
               state = ExecutionStatus.PAUSE;
           }else if(processInstanceState == ExecutionStatus.READY_STOP
                   || processInstanceState == ExecutionStatus.FAILURE) {
               state = ExecutionStatus.KILL;
           }else{
               state = ExecutionStatus.SUBMITTED_SUCCESS;
           }
   ```
   
   @lenboo 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services