codecov-io edited a comment on issue #2204: Refactor ConnectionFactory to static inner holder Singleton URL: https://github.com/apache/incubator-dolphinscheduler/pull/2204#issuecomment-599881906 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204?src=pr&el=h1) Report > Merging [#2204](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/0e5fb86bef1f62c64159aedd9ae1c5e361669fb0?src=pr&el=desc) will **increase** coverage by `0.77%`. > The diff coverage is `85.71%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## dev #2204 +/- ## ============================================ + Coverage 29.71% 30.48% +0.77% - Complexity 1629 1663 +34 ============================================ Files 336 336 Lines 17807 17787 -20 Branches 2238 2232 -6 ============================================ + Hits 5291 5423 +132 + Misses 11964 11808 -156 - Partials 552 556 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/dolphinscheduler/dao/upgrade/UpgradeDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3VwZ3JhZGUvVXBncmFkZURhby5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...java/org/apache/dolphinscheduler/dao/AlertDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL0FsZXJ0RGFvLmphdmE=) | `8.33% <100%> (+5%)` | `2 <1> (+1)` | :arrow_up: | | [...hinscheduler/dao/datasource/ConnectionFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQ29ubmVjdGlvbkZhY3RvcnkuamF2YQ==) | `88.88% <88%> (+88.88%)` | `8 <4> (+8)` | :arrow_up: | | [...ache/dolphinscheduler/server/utils/ParamUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1BhcmFtVXRpbHMuamF2YQ==) | `83.87% <0%> (-3.23%)` | `9% <0%> (-1%)` | | | [...dolphinscheduler/server/worker/task/TaskProps.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1Rhc2tQcm9wcy5qYXZh) | `39.18% <0%> (-2.71%)` | `21% <0%> (-1%)` | | | [...nscheduler/server/worker/task/datax/DataxTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL2RhdGF4L0RhdGF4VGFzay5qYXZh) | `72.72% <0%> (-1.92%)` | `17% <0%> (-2%)` | | | [...inscheduler/common/task/datax/DataxParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svZGF0YXgvRGF0YXhQYXJhbWV0ZXJzLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `81.66% <0%> (+6.66%)` | `15% <0%> (+1%)` | :arrow_up: | | [...pache/dolphinscheduler/alert/utils/ExcelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FeGNlbFV0aWxzLmphdmE=) | `88.88% <0%> (+7.4%)` | `9% <0%> (+1%)` | :arrow_up: | | [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `100% <0%> (+8.69%)` | `8% <0%> (+1%)` | :arrow_up: | | ... and [5 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204?src=pr&el=footer). Last update [0e5fb86...9e5c874](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2204?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
