codecov-io commented on issue #2256: taskProps.getScheduleTime() may be null, but there is no check if it … URL: https://github.com/apache/incubator-dolphinscheduler/pull/2256#issuecomment-601998369 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256?src=pr&el=h1) Report > Merging [#2256](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/ff0d6c6c5fc2ae0f86a6ad013019d253e580160c&el=desc) will **decrease** coverage by `1.50%`. > The diff coverage is `28.17%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## dev #2256 +/- ## ============================================ - Coverage 31.95% 30.44% -1.51% - Complexity 1511 1665 +154 ============================================ Files 311 337 +26 Lines 15402 17831 +2429 Branches 1864 2240 +376 ============================================ + Hits 4922 5429 +507 - Misses 9968 11846 +1878 - Partials 512 556 +44 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...heduler/alert/manager/EnterpriseWeChatManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9tYW5hZ2VyL0VudGVycHJpc2VXZUNoYXRNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...duler/alert/template/impl/DefaultHTMLTemplate.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9pbXBsL0RlZmF1bHRIVE1MVGVtcGxhdGUuamF2YQ==) | `77.55% <ø> (ø)` | `13.00 <0.00> (+1.00)` | | | [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...apache/dolphinscheduler/alert/utils/FuncUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9GdW5jVXRpbHMuamF2YQ==) | `91.66% <ø> (ø)` | `5.00 <0.00> (ø)` | | | [...che/dolphinscheduler/api/ApiApplicationServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL0FwaUFwcGxpY2F0aW9uU2VydmVyLmphdmE=) | `33.33% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...scheduler/api/controller/AlertGroupController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvQWxlcnRHcm91cENvbnRyb2xsZXIuamF2YQ==) | `3.57% <0.00%> (-0.52%)` | `2.00 <0.00> (ø)` | | | [...heduler/api/controller/DataAnalysisController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRGF0YUFuYWx5c2lzQ29udHJvbGxlci5qYXZh) | `5.40% <0.00%> (ø)` | `2.00 <0.00> (ø)` | | | [...scheduler/api/controller/DataSourceController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRGF0YVNvdXJjZUNvbnRyb2xsZXIuamF2YQ==) | `2.19% <0.00%> (ø)` | `2.00 <0.00> (ø)` | | | [...inscheduler/api/controller/ExecutorController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRXhlY3V0b3JDb250cm9sbGVyLmphdmE=) | `6.25% <0.00%> (ø)` | `2.00 <0.00> (ø)` | | | [...nscheduler/api/controller/ResourcesController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvUmVzb3VyY2VzQ29udHJvbGxlci5qYXZh) | `1.33% <0.00%> (+<0.01%)` | `2.00 <0.00> (ø)` | | | ... and [135 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256?src=pr&el=footer). Last update [ca6872a...57450c0](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
