codecov-io edited a comment on issue #2254: Connection mode of adding Sid to Oracle URL: https://github.com/apache/incubator-dolphinscheduler/pull/2254#issuecomment-601988655 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254?src=pr&el=h1) Report > Merging [#2254](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1fe5b31468aa62f8477bc17044d7519403f8ee12&el=desc) will **increase** coverage by `0.53%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## dev #2254 +/- ## ============================================ + Coverage 30.46% 30.99% +0.53% - Complexity 1665 1690 +25 ============================================ Files 337 338 +1 Lines 17830 17846 +16 Branches 2238 2240 +2 ============================================ + Hits 5432 5532 +100 + Misses 11843 11741 -102 - Partials 555 573 +18 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...scheduler/api/controller/DataSourceController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRGF0YVNvdXJjZUNvbnRyb2xsZXIuamF2YQ==) | `23.07% <0.00%> (+20.87%)` | `8.00 <0.00> (+6.00)` | | | [...olphinscheduler/api/service/DataSourceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YVNvdXJjZVNlcnZpY2UuamF2YQ==) | `11.65% <0.00%> (+10.99%)` | `8.00 <0.00> (+6.00)` | | | [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `82.35% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...e/dolphinscheduler/common/enums/DbConnectType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0RiQ29ubmVjdFR5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...phinscheduler/dao/datasource/OracleDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvT3JhY2xlRGF0YVNvdXJjZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `75.00% <0.00%> (-6.67%)` | `14.00% <0.00%> (-1.00%)` | | | [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `74.59% <0.00%> (+0.32%)` | `65.00% <0.00%> (+1.00%)` | | | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `74.95% <0.00%> (+0.34%)` | `84.00% <0.00%> (+1.00%)` | | | [...rg/apache/dolphinscheduler/api/utils/PageInfo.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL1BhZ2VJbmZvLmphdmE=) | `41.66% <0.00%> (+2.77%)` | `7.00% <0.00%> (+2.00%)` | | | ... and [7 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254?src=pr&el=footer). Last update [1fe5b31...e09ae18](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2254?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
