codecov-io edited a comment on issue #2256: taskProps.getScheduleTime() may be null, but there is no check if it … URL: https://github.com/apache/incubator-dolphinscheduler/pull/2256#issuecomment-601998369 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256?src=pr&el=h1) Report > Merging [#2256](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/eef8bf4e6de199313499477ac6f8dbac1512f2da&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `71.42%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## dev #2256 +/- ## ============================================ + Coverage 31.07% 31.11% +0.04% - Complexity 1708 1709 +1 ============================================ Files 337 337 Lines 17679 17680 +1 Branches 2206 2207 +1 ============================================ + Hits 5494 5502 +8 + Misses 11623 11616 -7 Partials 562 562 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...nscheduler/server/worker/task/shell/ShellTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL3NoZWxsL1NoZWxsVGFzay5qYXZh) | `77.77% <71.42%> (+13.62%)` | `6.00 <0.00> (+1.00)` | | | [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `91.30% <0.00%> (-8.70%)` | `7.00% <0.00%> (-1.00%)` | | | [...dolphinscheduler/server/worker/task/TaskProps.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1Rhc2tQcm9wcy5qYXZh) | `44.59% <0.00%> (+2.70%)` | `23.00% <0.00%> (+1.00%)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256?src=pr&el=footer). Last update [eef8bf4...986d19c](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2256?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
