Technoboy- commented on a change in pull request #2420: 1，no worker condition ,
master will while ture wait for worker startup 2，worker response task status
sync wait for result
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/2420#discussion_r408647772
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumer.java
##########
@@ -114,13 +114,19 @@ public void run() {
private Boolean dispatch(int taskInstanceId){
TaskExecutionContext context = getTaskExecutionContext(taskInstanceId);
ExecutionContext executionContext = new
ExecutionContext(context.toCommand(), ExecutorType.WORKER,
context.getWorkerGroup());
- try {
- return dispatcher.dispatch(executionContext);
- } catch (ExecuteException e) {
- logger.error("execute exception", e);
- return false;
- }
+ Boolean result = false;
+ while (Stopper.isRunning()){
+ try {
+ result = dispatcher.dispatch(executionContext);
+ } catch (ExecuteException e) {
+ logger.error("dispatch error",e);
Review comment:
when error， should sleep(200~1000).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
