lenboo commented on a change in pull request #2560:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/2560#discussion_r417810041
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java
##########
@@ -563,35 +563,43 @@ private String getResourceIds(ProcessData processData) {
}
/**
- * export process definition by id
- *
- * @param loginUser login user
- * @param projectName project name
- * @param processDefinitionId process definition id
- * @param response response
+ * batch export process definition by ids
+ * @param loginUser
+ * @param projectName
+ * @param processDefinitionIds
+ * @param response
*/
- public void exportProcessDefinitionById(User loginUser, String
projectName, Integer processDefinitionId, HttpServletResponse response) {
+ public void batchExportProcessDefinitionByIds(User loginUser, String
projectName, String processDefinitionIds, HttpServletResponse response){
Review comment:
can you reduce complexity here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
