743294668 opened a new pull request #2792: URL: https://github.com/apache/incubator-dolphinscheduler/pull/2792
## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.* ## What is the purpose of the pull request This pull request modify the JDBC format of the Oracle database connection. Number:#2791 The Oracle JDBC link I verified currently supports the following three methods: jdbc:oracle:thin:@host:port:SID jdbc:oracle:thin:@//host:port/service_name jdbc:oracle:thin:@host:port/service_name The above three methods are verified in the unit test. ## Brief change log *(for example:)* - DataSourceService.java: Add Oracle link type parameter in buildParameter(). - OracleDataSource.java: Rewrite Oracle's getJdbcUrl () method, according to the newly added Oracle link type judgment in the incoming parameters. - BaseDataSourceTest.java: Unit test the newly modified code. - Constants.java: Add ORACLE_DB_CONNECT_TYPE type. ## Verify this pull request This change added tests and can be verified as follows: - Add the Oracle data source in the data source center, including using the service name or SID. - Perform the task of executing the Oracle data source on the SQL type node and pass the verification. ##Addition If anything is wrong, you are welcome to participate in the discussion. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
