743294668 opened a new pull request #2832: URL: https://github.com/apache/incubator-dolphinscheduler/pull/2832
## What is the purpose of the pull request This pull request modify the JDBC format of the Oracle database connection. Number:#2791. pull/2792 ，pull/2818has been abandoned for other reasons. The Oracle JDBC link I verified currently supports the following three methods: jdbc:oracle:thin:@host:port:SID jdbc:oracle:thin:@//host:port/service_name jdbc:oracle:thin:@host:port/service_name The above three methods are verified in the unit test. ## Brief change log DataSourceService.java: Add Oracle link type parameter in buildParameter(). BaseDataSource.java: Modify appendDatabase () method as a protected modifier to facilitate OracleDataSource to rewrite this method. OracleDataSource.java: Override appendDatabase () method. OracleDataSourceTest.java: Unit test the newly modified code. DataSourceServiceTest.java: Add buildParameter () unit test. pom.xml: added a line in the maven-surefire-plugin section of the pom file to ensure that my OracleDataSourceTest.java file can be executed, thus ensuring my code coverage. ## Verify this pull request This change added tests and can be verified as follows: Add the Oracle data source in the data source center, including using the service name or SID. Perform the task of executing the Oracle data source on the SQL type node and pass the verification. ##Addition If anything is wrong, you are welcome to participate in the discussion. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
