Eights-Li commented on a change in pull request #2838:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/2838#discussion_r432359890



##########
File path: 
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/DolphinSchedulerManager.java
##########
@@ -112,11 +112,12 @@ public void upgradeDolphinScheduler() throws Exception{
             for(String schemaDir : schemaList) {
                 schemaVersion = schemaDir.split("_")[0];
                 if(SchemaUtils.isAGreatVersion(schemaVersion , version)) {
-
-                    logger.info("upgrade DolphinScheduler metadata version 
from " + version + " to " + schemaVersion);
-
+                    logger.info("upgrade DolphinScheduler metadata version 
from {} to {}", version, schemaVersion);
                     logger.info("Begin upgrading DolphinScheduler's table 
structure");
                     upgradeDao.upgradeDolphinScheduler(schemaDir);
+                    if (upgradeDao.isExistsTable("t_ds_worker_group")) {

Review comment:
       Yes, need according to ds-version to exec upgrade worker group




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to