ORuteMa commented on code in PR #14237:
URL: 
https://github.com/apache/dolphinscheduler/pull/14237#discussion_r1210361651


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkArgsUtils.java:
##########
@@ -164,12 +164,9 @@ public static List<String> 
buildInitOptionsForSql(FlinkParameters flinkParameter
             }
 
             // yarn.application.queue
-            String others = flinkParameters.getOthers();
-            if (StringUtils.isEmpty(others) || 
!others.contains(FlinkConstants.FLINK_QUEUE)) {
-                String queue = flinkParameters.getQueue();
-                if (StringUtils.isNotEmpty(queue)) {
-                    
initOptions.add(String.format(FlinkConstants.FLINK_FORMAT_YARN_APPLICATION_QUEUE,
 queue));
-                }
+            String queue = flinkParameters.getQueue();
+            if (StringUtils.isNotEmpty(queue)) {

Review Comment:
   The execution of a workflow is tied to a specific tenant, and this tenant 
holds a queue attribute. This attribute is assigned to the processInstance 
being executed by the tenant. The queue attribute of the executionContext for 
any taskInstance belonging to this processInstance will also be consistent. 
Therefore, the queue of a task is ultimately determined by the queue attribute 
of the runtime tenant if not explicitly specified.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to