Radeity commented on code in PR #14349:
URL:
https://github.com/apache/dolphinscheduler/pull/14349#discussion_r1229499052
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/ldap/LdapService.java:
##########
@@ -70,6 +70,15 @@ public class LdapService {
@Value("${security.authentication.ldap.user.not-exist-action:CREATE}")
private String ldapUserNotExistAction;
+ @Value("${security.authentication.ldap.ssl.enable:false}")
+ private Boolean sslEnable;
+
+ @Value("${security.authentication.ldap.ssl.trust-store:#{null}}")
+ private String trustStore;
+
+ @Value("${security.authentication.ldap.ssl.trust-store-password:#{null}}")
+ private String trustStorePassword;
Review Comment:
Can we set replace default null value with the same value in
`application.yaml`? I think keep consistent is better and can also avoid NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
