xdu-chenrj commented on issue #14338: URL: https://github.com/apache/dolphinscheduler/issues/14338#issuecomment-1598046474
> Hello @xdu-chenrj , > > Basically LGTM. > > There are three things you could take into consideration: > > 1. How to make sure developers would not accidentally log these credentials of task plugins? > 2. Is it possible to merge the two modules - `dolphinscheduler-task-plugin` and `dolphinscheduler-datasource-plugin`? > 3. If contributors want to contribute a new task plugin with parameters, what is the guideline and best practice? 1. For problem one, we may need to individually adapt credential blocking for each task, such as #10498. 2. For question two, I haven't figured it out yet, I may need some time. 3. For question three, I will write a document at the end that tells developers how to develop a new task plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
