zhongjiajie commented on code in PR #14406:
URL:
https://github.com/apache/dolphinscheduler/pull/14406#discussion_r1244596316
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/Constants.java:
##########
@@ -850,4 +850,9 @@ private Constants() {
public static final String REMOTE_LOGGING_GCS_CREDENTIAL =
"remote.logging.google.cloud.storage.credential";
public static final String REMOTE_LOGGING_GCS_BUCKET_NAME =
"remote.logging.google.cloud.storage.bucket.name";
+
+ /**
+ * data quality
+ */
+ public static final String DATABASES_QUERY = "show databases";
Review Comment:
postgresql seem not work with this statement
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java:
##########
@@ -645,6 +643,55 @@ public Map<String, Object> getTableColumns(Integer
datasourceId, String tableNam
return result;
}
+ @Override
+ public Map<String, Object> getDatabases(Integer datasourceId) {
Review Comment:
could we directly return `List<ParamsOptions>` and wrapper to `Result` in
the controller?
##########
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.2.0_schema/mysql/dolphinscheduler_dml.sql:
##########
@@ -37,3 +37,48 @@ DROP PROCEDURE dolphin_t_ds_tenant_insert_default;
-- tenant improvement
UPDATE t_ds_schedules t1 JOIN t_ds_process_definition t2 ON
t1.process_definition_code = t2.code LEFT JOIN t_ds_tenant t3 ON t2.tenant_id =
t3.id SET t1.tenant_code = COALESCE(t3.tenant_code, 'default');
UPDATE `t_ds_process_instance` SET `tenant_code` = 'default' WHERE
`tenant_code` IS NULL;
+
+-- data quality support choose database
+INSERT IGNORE INTO `t_ds_dq_rule_input_entry`
Review Comment:
can you use PROCEDURE like `dolphin_t_ds_tenant_insert_default ` instead of
bare sql here?
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataSourceController.java:
##########
@@ -342,27 +343,43 @@ public Result getKerberosStartupState(@Parameter(hidden =
true) @RequestAttribut
@Operation(summary = "tables", description = "GET_DATASOURCE_TABLES_NOTES")
@Parameters({
- @Parameter(name = "datasourceId", description = "DATA_SOURCE_ID",
required = true, schema = @Schema(implementation = int.class, example = "1"))
+ @Parameter(name = "datasourceId", description = "DATA_SOURCE_ID",
required = true, schema = @Schema(implementation = int.class, example = "1")),
Review Comment:
could you add this change to `incompatible.md`? because we change the
interface of public method
##########
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.2.0_schema/mysql/dolphinscheduler_dml.sql:
##########
@@ -37,3 +37,48 @@ DROP PROCEDURE dolphin_t_ds_tenant_insert_default;
-- tenant improvement
UPDATE t_ds_schedules t1 JOIN t_ds_process_definition t2 ON
t1.process_definition_code = t2.code LEFT JOIN t_ds_tenant t3 ON t2.tenant_id =
t3.id SET t1.tenant_code = COALESCE(t3.tenant_code, 'default');
UPDATE `t_ds_process_instance` SET `tenant_code` = 'default' WHERE
`tenant_code` IS NULL;
+
+-- data quality support choose database
+INSERT IGNORE INTO `t_ds_dq_rule_input_entry`
Review Comment:
and some as pg upgrade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
