zhongjiajie commented on code in PR #14415:
URL:
https://github.com/apache/dolphinscheduler/pull/14415#discussion_r1244603755
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-email/src/test/java/org/apache/dolphinscheduler/plugin/alert/email/EmailAlertChannelTest.java:
##########
@@ -107,7 +106,7 @@ public String getEmailAlertParams() {
.setValue("[email protected]")
.build();
- PasswordParam mailPassword =
PasswordParam.newBuilder(MailParamsConstants.NAME_MAIL_PASSWD, "passwd")
+ InputParam mailPassword =
InputParam.newBuilder(MailParamsConstants.NAME_MAIL_PASSWD, "passwd")
.setPlaceholder("if enable use authentication, you need input
password")
.setValue("escheduler123")
Review Comment:
does `escheduler123 ` is a default value? if also we should remove it or
change to `dolphinscheduler`
I guess `escheduler` is for `easy scheduler` is pervious name of
dolphinscheduler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
