zhongjiajie commented on code in PR #14394:
URL:
https://github.com/apache/dolphinscheduler/pull/14394#discussion_r1244606510
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ResourcesController.java:
##########
@@ -124,11 +122,10 @@ public class ResourcesController extends BaseController {
public Result<Object> createDirectory(@Parameter(hidden = true)
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@RequestParam(value = "type")
ResourceType type,
@RequestParam(value = "name") String
alias,
- @RequestParam(value = "description",
required = false) String description,
@RequestParam(value = "pid") int pid,
@RequestParam(value = "currentDir")
String currentDir) {
// todo verify the directory name
- return resourceService.createDirectory(loginUser, alias, description,
type, pid, currentDir);
Review Comment:
could you add some desc to `incompatible.md` due to we change the public
interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
