Radeity commented on code in PR #14406:
URL:
https://github.com/apache/dolphinscheduler/pull/14406#discussion_r1244631045
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataSourceController.java:
##########
@@ -342,27 +343,43 @@ public Result getKerberosStartupState(@Parameter(hidden =
true) @RequestAttribut
@Operation(summary = "tables", description = "GET_DATASOURCE_TABLES_NOTES")
@Parameters({
- @Parameter(name = "datasourceId", description = "DATA_SOURCE_ID",
required = true, schema = @Schema(implementation = int.class, example = "1"))
+ @Parameter(name = "datasourceId", description = "DATA_SOURCE_ID",
required = true, schema = @Schema(implementation = int.class, example = "1")),
+ @Parameter(name = "database", description = "DATABASE", required =
true, schema = @Schema(implementation = String.class, example = "test"))
})
@GetMapping(value = "/tables")
@ResponseStatus(HttpStatus.OK)
@ApiException(GET_DATASOURCE_TABLES_ERROR)
- public Result getTables(@RequestParam("datasourceId") Integer
datasourceId) {
- Map<String, Object> result = dataSourceService.getTables(datasourceId);
+ public Result getTables(@RequestParam("datasourceId") Integer datasourceId,
+ @RequestParam(value = "database") String database)
{
+ Map<String, Object> result = dataSourceService.getTables(datasourceId,
database);
return returnDataList(result);
}
@Operation(summary = "tableColumns", description =
"GET_DATASOURCE_TABLE_COLUMNS_NOTES")
@Parameters({
@Parameter(name = "datasourceId", description = "DATA_SOURCE_ID",
required = true, schema = @Schema(implementation = int.class, example = "1")),
+ @Parameter(name = "database", description = "DATABASE", required =
true, schema = @Schema(implementation = String.class, example = "test")),
@Parameter(name = "tableName", description = "TABLE_NAME",
required = true, schema = @Schema(implementation = String.class, example =
"test"))
Review Comment:
Better keep the same order with the following parameter declaration :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
