SbloodyS commented on code in PR #14392:
URL: 
https://github.com/apache/dolphinscheduler/pull/14392#discussion_r1244854786


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java:
##########
@@ -253,16 +252,8 @@ public Map<String, Object> queryTaskGroupByStatus(User 
loginUser, int pageNo, in
     public Map<String, Object> queryTaskGroupByProjectCode(User loginUser, int 
pageNo, int pageSize, Long projectCode) {
         Map<String, Object> result = new HashMap<>();
         Page<TaskGroup> page = new Page<>(pageNo, pageSize);
-        PageInfo<TaskGroup> emptyPageInfo = new PageInfo<>(pageNo, pageSize);
-        Set<Integer> ids = 
resourcePermissionCheckService.userOwnedResourceIdsAcquisition(AuthorizationType.TASK_GROUP,
-                loginUser.getId(), log);

Review Comment:
   > In another word, only when the user is granted permission of one project, 
he can find task groups belongs to the project. Can it be seen as a user-level 
permission control?
   
   That's a good question...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to