JadenQ opened a new pull request, #14429: URL: https://github.com/apache/dolphinscheduler/pull/14429
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! --> ## Purpose of the pull request - Add a task event condition to handle, when the task is timeout, the stateEvent somehow doesn't change, so the code will fall into the condition mentioned here [https://github.com/apache/dolphinscheduler/issues/14428](url). - The task failure situation is not handled, so the working thread will stuck on running and if there are more and more workflow stuck on running, the thread pool will be overwelmed. ## Brief change log 2. Why this change work - Handle the task failure, use taskFinished to further process task retry, failover, workflow status update works. - The taskFinished is well developed to handle further situation, calling this function does not create extra issue in task scheduling. 3. Why this is urgent Restart the DS cluster with this situation can lead to further dead loop situation caused by the inappropriate operates for task submit process. I will try to reproduce it and report further if you may interested. ## Verify this pull request <!--*(Please pick either of the following options)*--> This pull request is code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: Tried this change on my cluster, and this can help update the workflow status and properly process the task and workflow scheduling including retry and failover as developed in other modules. If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
