gabrywu commented on a change in pull request #2872:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/2872#discussion_r435930528
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java
##########
@@ -636,7 +636,7 @@ private void
downloadProcessDefinitionFile(HttpServletResponse response, List<Pr
try {
out = response.getOutputStream();
buff = new BufferedOutputStream(out);
-
buff.write(JSON.toJSONString(processDefinitionList).getBytes(StandardCharsets.UTF_8));
+
buff.write(JSONUtils.toJsonString(processDefinitionList).getBytes(StandardCharsets.UTF_8));
Review comment:
It's better add test code into JSONUtils.toJsonString to cover the
List<ProcessMeta> parameter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
