EricGao888 commented on code in PR #14434:
URL:
https://github.com/apache/dolphinscheduler/pull/14434#discussion_r1253904862
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java:
##########
@@ -385,6 +385,15 @@ public Result<Object> checkConnection(DbType type,
ConnectionParam connectionPar
}
return result;
}
+ if (type == DbType.ZEPPELIN) {
Review Comment:
If you plan to improve this later when merging two modules and refactoring
related code, you should add a `TDOD` comment here at least : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
