huaibingshifu commented on code in PR #14473:
URL:
https://github.com/apache/dolphinscheduler/pull/14473#discussion_r1257444074
##########
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/AbstractDataSourceProcessor.java:
##########
@@ -109,6 +109,6 @@ protected Map<String, String>
transformOtherParamToMap(String other) {
public String getDatasourceUniqueId(ConnectionParam connectionParam,
DbType dbType) {
BaseConnectionParam baseConnectionParam = (BaseConnectionParam)
connectionParam;
return MessageFormat.format("{0}@{1}@{2}@{3}", dbType.getDescp(),
baseConnectionParam.getUser(),
-
PasswordUtils.encodePassword(baseConnectionParam.getPassword()),
baseConnectionParam.getJdbcUrl());
+
PasswordUtils.encodePassword(baseConnectionParam.getPassword()),
getJdbcUrl(connectionParam));
Review Comment:
The cache expires within 24 hours, and the cache does not necessarily need
to expire when updatingDataSource. Is it better to change getDatasourceUniqueId?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
