This is an automated email from the ASF dual-hosted git repository.

songjian pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new 4111acb58e [Bug] [Seatunnel-Task] Run Mode defaults to run, and you 
cannot select a null value (#14267)
4111acb58e is described below

commit 4111acb58e1ae5e5c67047f995d59d91a496f10f
Author: zyfjrx <[email protected]>
AuthorDate: Wed Jul 12 09:06:19 2023 +0800

    [Bug] [Seatunnel-Task] Run Mode defaults to run, and you cannot select a 
null value (#14267)
    
    Co-authored-by: zhang <[email protected]>
---
 .../plugin/task/seatunnel/flink/SeatunnelFlinkParameters.java  |  1 +
 .../plugin/task/seatunnel/flink/SeatunnelFlinkTask.java        | 10 +++++++---
 .../projects/task/components/node/fields/use-sea-tunnel.ts     |  4 ++++
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git 
a/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkParameters.java
 
b/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkParameters.java
index 1d85ea0267..0c4bf34046 100644
--- 
a/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkParameters.java
+++ 
b/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkParameters.java
@@ -35,6 +35,7 @@ public class SeatunnelFlinkParameters extends 
SeatunnelParameters {
     @Getter
     public enum RunModeEnum {
 
+        NONE("none"),
         RUN("--run-mode run"),
         RUN_APPLICATION("--run-mode run-application");
 
diff --git 
a/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkTask.java
 
b/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkTask.java
index 2efbc8e5c3..32d5fa3e05 100644
--- 
a/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkTask.java
+++ 
b/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkTask.java
@@ -44,9 +44,13 @@ public class SeatunnelFlinkTask extends SeatunnelTask {
     @Override
     public List<String> buildOptions() throws Exception {
         List<String> args = super.buildOptions();
-        args.add(
-                Objects.isNull(seatunnelParameters.getRunMode()) ? 
SeatunnelFlinkParameters.RunModeEnum.RUN.getCommand()
-                        : seatunnelParameters.getRunMode().getCommand());
+        if (!(Objects.isNull(seatunnelParameters.getRunMode())
+                && 
SeatunnelFlinkParameters.RunModeEnum.NONE.equals(seatunnelParameters.getRunMode())))
 {
+            args.add(
+                    Objects.isNull(seatunnelParameters.getRunMode())
+                            ? 
SeatunnelFlinkParameters.RunModeEnum.RUN.getCommand()
+                            : seatunnelParameters.getRunMode().getCommand());
+        }
         if (StringUtils.isNotBlank(seatunnelParameters.getOthers())) {
             args.add(seatunnelParameters.getOthers());
         }
diff --git 
a/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-sea-tunnel.ts
 
b/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-sea-tunnel.ts
index 980fd86d9a..7931e83049 100644
--- 
a/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-sea-tunnel.ts
+++ 
b/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-sea-tunnel.ts
@@ -196,6 +196,10 @@ export const STARTUP_SCRIPT = [
 ]
 
 export const FLINK_RUN_MODE = [
+  {
+    label: 'none',
+    value: 'NONE'
+  },
   {
     label: 'run',
     value: 'RUN'

Reply via email to