Radeity commented on code in PR #14379:
URL:
https://github.com/apache/dolphinscheduler/pull/14379#discussion_r1260495807
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/AbstractCommandExecutor.java:
##########
@@ -327,7 +327,7 @@ private void collectPodLogIfNeeded() {
ThreadUtils.sleep(SLEEP_TIME_MILLIS * 5L);
try (
LogWatch watcher =
ProcessUtils.getPodLogWatcher(taskRequest.getK8sTaskExecutionContext(),
- taskRequest.getTaskAppId())) {
+ taskRequest.getTaskAppId(), "")) {
Review Comment:
In `AbstractCommandExecutor`, only need to get log watcher for Spark on K8S
task, and we directly collect logs from driver pod, however, we can not set
container name during task launching. Thus, we set empty string and the effect
is same as collecting logs from all containers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
