hoey94 opened a new issue, #14517:
URL: https://github.com/apache/dolphinscheduler/issues/14517

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   When I reviewed the DataSrouceServiceImpl.getDatabases() function, I found a 
logical error in the original code:
   ```java
   if (dataSource.getType() == DbType.POSTGRESQL) {
       rs = 
connection.createStatement().executeQuery(Constants.DATABASES_QUERY_PG);
   } 
   rs = connection.createStatement().executeQuery(Constants.DATABASES_QUERY);
   ```
   new code:
   ```java
   if (dataSource.getType() == DbType.POSTGRESQL) {
       rs = 
connection.createStatement().executeQuery(Constants.DATABASES_QUERY_PG);
   } else {
       rs = 
connection.createStatement().executeQuery(Constants.DATABASES_QUERY);
   }
   ```
   
   ### What you expected to happen
   
   successfully retrieved postgres databases
   
   ### How to reproduce
   
   When using Postgre database to store metadata, the function 
DataSrouceServiceImpl.getDatabases() is called.
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   dev
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to