qingwli commented on code in PR #14455:
URL:
https://github.com/apache/dolphinscheduler/pull/14455#discussion_r1260828840
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/CheckType.java:
##########
@@ -36,7 +36,9 @@ public enum CheckType {
COMPARISON_MINUS_STATISTICS(0, "comparison_minus_statistics"),
STATISTICS_MINUS_COMPARISON(1, "statistics_minus_comparison"),
STATISTICS_COMPARISON_PERCENTAGE(2, "statistics_comparison_percentage"),
- STATISTICS_COMPARISON_DIFFERENCE_COMPARISON_PERCENTAGE(3,
"statistics_comparison_difference_comparison_percentage");
+ STATISTICS_COMPARISON_DIFFERENCE_COMPARISON_PERCENTAGE(3,
"statistics_comparison_difference_comparison_percentage"),
+ ABSOLUTE_VALUE_COMPARISON_STATISTICS(4,
"ABSOLUTE_VALUE_OF_COMPARISON_STATISTICS"),
Review Comment:
```suggestion
ABSOLUTE_VALUE_COMPARISON_STATISTICS(4,
"absolute_value_of_comparison_statistics"),
```
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-dataquality/src/main/java/org/apache/dolphinscheduler/plugin/task/dq/rule/RuleManager.java:
##########
@@ -107,6 +110,7 @@ public DataQualityConfiguration
generateDataQualityParameter() throws RuntimeExc
RuleParserUtils.getInputParameterMapFromEntryList(
JSONUtils.toList(dataQualityTaskExecutionContext.getRuleInputEntryList(),
DqRuleInputEntry.class));
+ log.debug("inputParameterValueResult: " + inputParameterValueResult);
inputParameterValueResult.putAll(inputParameterValue);
Review Comment:
Do we need to push `log.debug` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
