genuinner opened a new issue, #14541:
URL: https://github.com/apache/dolphinscheduler/issues/14541

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar feature requirement.
   
   
   ### Description
   
   when I study  adding datasource plugin, i find the datasource-special 
constants like `COM_CLICKHOUSE_JDBC_DRIVER = 
"com.clickhouse.jdbc.ClickHouseDriver"` only used in 
ClickHouseDataSourceProcessor, so i move all related constant to the special 
DataSourceProcessor, it does not make too much sense, I just think it is a 
better format and pattern, after that, I can easily setDefaultValidationQuery 
to fit various datasource, which has problem using the original code.
   So you can evaluate if this change is needed.
   
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to