Orange-Summer commented on code in PR #14552:
URL:
https://github.com/apache/dolphinscheduler/pull/14552#discussion_r1266491762
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThreadPool.java:
##########
@@ -182,6 +185,18 @@ private void notifyProcessChanged(ProcessInstance
finishProcessInstance) {
}
}
+ private void crossWorkflowParameterPassing(ProcessInstance
finishProcessInstance, TaskInstance taskInstance) {
+ try {
+ MasterTaskExecuteRunnable masterTaskExecuteRunnable =
+
MasterTaskExecuteRunnableHolder.getMasterTaskExecuteRunnable(taskInstance.getId());
+ masterTaskExecuteRunnable.getILogicTask().getTaskParameters()
+ .setVarPool(finishProcessInstance.getVarPool());
+ log.info("Cross workflow parameter passing success,
processInstanceId: {}, taskInstanceId");
Review Comment:
Sorry, I didn't check carefully
`log.info("Cross workflow parameter passing success,
finishProcessInstanceId: {}, taskInstanceId: {}",
finishProcessInstance.getId(), taskInstance.getId());`
is this ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
